About page #34
About page #34
Conversation
|
The whole organizing group needs to approve the text :) |
ferbsx
requested review from
amrabdelwahab,
kajatiger,
pascalwengerter and
shushugah
There was a problem hiding this comment.
There are some topic changes, especially about diversity that we can continue discussing in near future. They are not blockers for me, however the typos should be addressed immediately. And I did not search for it, but all /code curious/\i mentions should be lower cased consistently, regardless of whether it's beginning of sentence or not.
| --- | ||
| title: "Rails Girls Berlin is growing up" | ||
| date: "2017-10-25" | ||
| coverImage: "IMG_0876b.jpg" |
There was a problem hiding this comment.
is this image used? We'll need to update the _config.yml as well to include /posts collections somehow, and specify the permalink structure there.
|
Also move this about.markdown file to |
| @@ -1,18 +1,66 @@ | |||
| --- | |||
| layout: page | |||
| title: About | |||
| title: What is code curious? | |||
There was a problem hiding this comment.
Keep in mind, the title is what is used for the "header link" text.
There was a problem hiding this comment.
I realized but I actually want it to be about on the header but on the page itself there should not be a big about.. how can I not have it show on the page itself?
impressum is a legal thing (like imprint) so it's not exactly the german translation of our about page. Kaja is now working on setting up our impressum. |
|
Nice! Let's delete a branch after merging it, shall we? @ferbsx |
addresses #24