Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add solution for 3rd LeetCode Practice Problem - Longest Substring Without Repeating Characters #184

Merged
merged 5 commits into from
Aug 2, 2021

Conversation

Git-Harshit
Copy link
Contributor

@Git-Harshit Git-Harshit commented Aug 1, 2021

Pull Request Template

Description

This commit adds a well-commented and human-readable Python 3 program to solve the third LeetCode Practice Problem viz., "Longest Substring Without Repeating Characters". The code is judged as Accepted on LeetCode, on 1st August 2021 (the same day this PR is initiated). Have a look, and feel free to suggest any changes or directly improvise the solution.

Put check marks:

Have you made changes in README file ?

  • Added problem & solution under correct topic.
  • Specified Space & Time complexity.
  • Specified difficulty level, tag & Note(if any).

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration.

  • Test A
  • Test B
  • Directly submitted the solution to LeetCode Judge (Result: Accepted)

Make sure all below guidelines are followed else PR will get Reject:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code so that it is easy to understand
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

…thout Repeating Characters

This commit adds a well-commented and human-readable Python 3 program to solve the third LeetCode Practice Problem viz., "Longest Substring Without Repeating Characters". The code is judged as Accepted on LeetCode, on 1st August 2021 (the same day this PR is initiated).
@welcome
Copy link

welcome bot commented Aug 1, 2021

I can tell this is your first pull request! Thank you I'm so honored. 🎉🎉🎉 I'll take a look at it ASAP!

Sorted Strings Table Entries in ascending order as per the # Problem ID column, and added entry for Python solution to newly added solution to Strings #3: Longest Substring Without Repeating Characters
@GouravRusiya30
Copy link
Member

GouravRusiya30 commented Aug 1, 2021

Thanks @Git-Harshit
Changes looks fine but can you change the file name of newly added python code to adhere to the naming conventions ?

@Git-Harshit
Copy link
Contributor Author

Git-Harshit commented Aug 1, 2021

Sure @GouravRusiya30, I will update the file name as per your naming convention.
I have looked into your README and CONTRIBUTING files before, but didn't get any code naming convention.

Update: Renamed the file as per naming convention <PROBLEM_NAME>.<FILE_FORMAT> as per the naming guideline mentioned in PULL_REQUEST_PROCESS file. I hope it's adhering to the naming conventions now. Please let me know if anything else can be improvised.

…t_Substring_Without_Repeating_Characters.py

Renamed this file to Longest_Substring_Without_Repeating_Characters.py in order to match file naming conventions of the repository, as mentioned in PULL_REQUEST_TEMPLATE
@GouravRusiya30
Copy link
Member

Thanks for updating the file name but you haven't updated the README with correct path of file.

Fixed the solution link for Longest_Substring_Without_Repeating_Characters.py file in README file
@Git-Harshit
Copy link
Contributor Author

Oops, My bad! I did forget about it. Thanks for pinging me on it. I have updated it on the README file too, please have a look again, it should be fine now. 🙂

@GouravRusiya30 GouravRusiya30 merged commit c046825 into codedecks-in:master Aug 2, 2021
@welcome
Copy link

welcome bot commented Aug 2, 2021

Your code looks great! Congrats, I've gone ahead and merged your first pull request! Keep it up! alt text

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants