Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker plugin updates #1056

Merged
merged 12 commits into from Oct 11, 2017

Conversation

codenrhoden
Copy link
Member

This patchset has a series of commits that update the Docker plugins. They are in separate commits for easier review, and potential to revert if something is wrong.

All Alpine-based plugins are upgraded from 3.5->3.6, except for s3fs, which does not compile on 3.6 due to the replacement of openssl with libressl.

The start scripts for REX-Ray no longer use the deprecated -f flag.

All drivers that use and HTTP API now support the HTTP_PROXY env var. This ends up being every plugin except Ceph RBD.

New global options for volume rootpath and filemode are added, except for S3FS which should be taken care of by #1042.

Many plugins had their options more fully brought in line with what is available to the full drivers -- but not all options apply to the Docker managed plugins, so there are still discrepancies.

Fixes #933
Fixes #1043

@codecov-io
Copy link

codecov-io commented Oct 9, 2017

Codecov Report

Merging #1056 into master will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1056      +/-   ##
==========================================
+ Coverage   34.16%   34.19%   +0.03%     
==========================================
  Files          36       36              
  Lines        2901     2901              
==========================================
+ Hits          991      992       +1     
+ Misses       1807     1806       -1     
  Partials      103      103
Impacted Files Coverage Δ
libstorage/api/types/types_localdevices.go 86.3% <0%> (+1.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update acfc364...39132af. Read the comment docs.

@codenrhoden codenrhoden force-pushed the enhancement/docker-plugins-updates branch from 4d94bfa to ffd9f34 Compare October 11, 2017 17:28
@codenrhoden
Copy link
Member Author

This has been rebased after #1042. It makes a small change from what #1042, which is to set the rootpath vars to an empty string, so that they use the default values in REX-Ray, rather than just explicitly setting them to /data, which is already the default.

@codenrhoden codenrhoden force-pushed the enhancement/docker-plugins-updates branch from ffd9f34 to c2b4545 Compare October 11, 2017 18:23
Except for S3FS -- unable to compile s3fs-fuse on Alpine 3.6 because 3.6
removed the openssl-dev package (containing libcrypto) and only
supportes libressl now. HOwever, s3fs-fuse does not compile against
libressl.
`rexray start -f` is deprecated, and current behavior of REX-Ray is to
always start in the foreground.
For each client that ultimately uses an HTTP based API, add the
HTTP_PROXY env var.
Add status timeout params, KMS key, and SDK retries
 Please enter the commit message for your changes. Lines starting
@codenrhoden codenrhoden force-pushed the enhancement/docker-plugins-updates branch from c2b4545 to 39132af Compare October 11, 2017 18:25
@akutz akutz merged commit 17bd4ea into rexray:master Oct 11, 2017
@codenrhoden codenrhoden deleted the enhancement/docker-plugins-updates branch October 11, 2017 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants