Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Props in ZoomableImage Component Usage in lesson 18 #8

Closed
astrxnomo opened this issue May 21, 2024 · 1 comment
Closed

Missing Props in ZoomableImage Component Usage in lesson 18 #8

astrxnomo opened this issue May 21, 2024 · 1 comment

Comments

@astrxnomo
Copy link

Issue

The ZoomableImage component is used in App.js without the required props imageURL and zoomFactor.

Expected

The ZoomableImage component should be used with the required props imageURL and zoomFactor to make it work properly.

Solution

Update the usage of ZoomableImage in App.js to include the required props. For example:

<ZoomableImage imageURL="https://i.imgur.com/ZIBbN09.jpeg" zoomFactor={10} />

Code reference

https://github.com/codedex-io/react-101/blob/75398d5176e8783f39f92e32d196d852c87da72e/4-events/18-a-focus-in-art/App.js#L7C3-L7C38

@Dusch4593
Copy link
Contributor

Hi @astrxnomo! 👋🏻

Great catch! I updated the solution with your suggestion in a10e1f4.

I also updated the instructions for exercise 18 to explicitly ask for the imageURL and zoomFactor props to be added to <ZoomableImage> in the App.js file.

Thank you so much! 🙏🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants