-
-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GOAWAY session_timed_out #81
Comments
In the process of fixing on the New intended behavior: |
shouldn't we just make the default ping period lower then? |
Tried variations down to 5 minutes with no luck. I'm not sure it respects pings, or when it does, |
Interesting... Dumb question, but I can't find any official documentation on whether FCM supports HTTP/2. Is this just an enhancement you've tried to make, and thus why we are running into so many problems? |
@cstar wrote the initial implementation. The API works fine except for the reconnect issue, which I'm guessing is due to FCM servers not wanting to persist socket connections until the API is public. I didn't discover it until I started rolling out onto some staging servers this morning. I should have the patch up pretty soon. |
Reconnects FCM socket only on subsequent pushes after a disconnect. Prevents infinite reconnect loop.
@hpopp I'm seeing this sporadically using pigeon 1.1.0 (c0d18bf) and kabadra 0.3.2 (d7afbcfa):
With various different stream ids. Should I be looking into the details of this, or is the session time out just business as usual? |
FCM closes the connection after idling for a minute or two. No big deal, it just reopens the next time a push is sent. I should probably have Kadabra disable logging by default. |
Thanks for the heads up - there doesn't appear to be any material impact on message delivery in any case, so we can just treat this as an ignorable log message. |
When using the FCM workers, I see a decent number of the
GOT GOAWAY, NO_ERROR
logs (which it seems like the worker code is aware of). Just wondering what the cause of this is and if there's a way I can mitigate it?The text was updated successfully, but these errors were encountered: