Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Header or footer not showing up. #11

Closed
jhunexjun opened this issue Jun 2, 2017 · 3 comments
Closed

Header or footer not showing up. #11

jhunexjun opened this issue Jun 2, 2017 · 3 comments

Comments

@jhunexjun
Copy link

I have this in web routes
Route::get('/fpdf', 'myController@method');
Then inside myController

<?php

namespace App\Http\Controllers;
use Illuminate\Http\Request;
use Fpdf;

class PDF extends Fpdf {
    function Header() {
    	$this->Image(storage_path() . 'logo.png',10,6,30);
    	$this->SetFont('Arial','B',15);
    	$this->Cell(80);
    	$this->Cell(30,10,'Title',1,0,'C');
    	$this->Ln(20);
    }
    function Footer() {
    	$this->SetY(-15);
    	$this->SetFont('Arial','I',8);
    	$this->Cell(0,10,'Page '.$this->PageNo().'/{nb}',0,0,'C');
    }
}

class myController extends Controller {
    public function method() {
    	$pdf = new PDF();
    	$pdf::AliasNbPages();
    	$pdf::AddPage();
    	$pdf::SetFont('Times','',12);

    	for($i=1;$i<=40;$i++)
    	    $pdf::Cell(0,10,'Printing line number '.$i,0,1);

	    $pdf::Output();
	    exit;
    }
}

The header and footer are not showing up only the main section. I don't see any errors.
Thanks.

@codedge
Copy link
Owner

codedge commented Jun 2, 2017

I'll have a look later this evening.

Just to clarify:

  • Your PDF class and your controller are in one single file?
  • Why are you having an exit statement at the end of your method method?
  • Why don't you use either Facades or proper dependency injection?

I think is sth. mixed up in your code. Nobody else is having this problem.

@codedge
Copy link
Owner

codedge commented Jun 2, 2017

As I supposed, not a problem with the package, but with your code.
Here is some help to fix!

Insert into routes/web.php:

Route::get('/fpdf', 'Controller@createPdf');

Create a model in app/Models/Pdf.php that extends the Pdf model from the package and override the Header and Footer method and do not do this in your controller file:

<?php

namespace App\Models;

use Codedge\Fpdf\Fpdf\Fpdf;

class Pdf extends Fpdf
{
    public function Header()
    {
        $this->Image(storage_path() . '/logo.jpg',10,6,30);
        $this->SetFont('Arial','B',15);
        $this->Cell(80);
        $this->Cell(30,10,'Title',1,0,'C');
        $this->Ln(20);
    }

    public function Footer()
    {
        $this->SetY(-15);
        $this->SetFont('Arial','I',8);
        $this->Cell(0,10,'Page '.$this->PageNo().'/{nb}',0,0,'C');
    }
}

In your controller, i. e. app/Http/Controllers/Controller.php you need to inject the Pdf model in the constructor like this:

<?php

namespace App\Http\Controllers;

use Illuminate\Foundation\Bus\DispatchesJobs;
use Illuminate\Routing\Controller as BaseController;
use Illuminate\Foundation\Validation\ValidatesRequests;
use Illuminate\Foundation\Auth\Access\AuthorizesRequests;

class Controller extends BaseController
{
    protected $pdf;

    public function __construct(\App\Models\Pdf $pdf)
    {
        $this->pdf = $pdf;
    }

    public function createPdf()
    {
        $this->pdf->AliasNbPages();
        $this->pdf->AddPage();
        $this->pdf->SetFont('Times','',12);

        for($i=1;$i<=40;$i++)
            $this->pdf->Cell(0,10,'Printing line number '.$i,0,1);

        $this->pdf->Output();
    }
}

The result is (with a different logo of course):
2017-06-02_22-56-23

@codedge codedge closed this as completed Jun 2, 2017
@jhunexjun
Copy link
Author

jhunexjun commented Jun 5, 2017

Hi,

I just want to answer your questions above.

  • Your PDF class and your controller are in one single file?
    Yes. Where it should be placed? I don't see it in some examples. Am I missing?

  • Why are you having an exit statement at the end of your method method?
    If there's no exit, it doesn't show as pdf in Chrome but full of unkown characters like

    %PDF-1.3 3 0 obj <> endobj 4 0 obj <> stream x�}.

    I noticed the content-type is not application/pdf but text/html; charset=UTF-8. The PDF shows though in Internet Explorer despite of the content-type.

  • Why don't you use either Facades or proper dependency injection?
    I don't see it in docs.

Thanks,

This was referenced Dec 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants