Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When there is no prebuilt composer template some vital options are missing #178

Open
gregharvey opened this issue Mar 26, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@gregharvey
Copy link
Member

If there's a ce-dev.compose.prebuilt.yml then it is simple copied to docker-compose.yml and all is fine, as long as your prebuilt file is correct. However, when there is only a ce-dev.compose.yml file and you run ce-dev init, it's the init.ts file that builds docker-compose.yml step by step. We have some options these days that are very important, specifically:

  # giving access to the host for local apps in macOS
  ports:
    - '3306:3306'
  # if this is missing containers cannot start
  cgroup: host
  # probably not vital, but we should set it
  platform: linux/amd64

We should make sure init.ts handles these parameters and can take them from ce-dev.compose.yml correctly, at the moment it builds docker-compose.yml files that make it impossible to start the containers if there is no prebuilt file.

@gregharvey gregharvey added the bug Something isn't working label Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant