Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type verification #174

Merged
merged 9 commits into from Feb 20, 2019
Merged

Type verification #174

merged 9 commits into from Feb 20, 2019

Conversation

wzorgdrager
Copy link
Collaborator

@wzorgdrager wzorgdrager commented Feb 19, 2019

Related issue(s): #160

Description of changes

Added pipeline verification system.

Check-list

Please make sure to review and check all of these items:

  • Are the updated classes tested?
  • Are the updated classes documented & properly formatted?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

@wzorgdrager wzorgdrager self-assigned this Feb 19, 2019
@wzorgdrager wzorgdrager added not ready This branch is not ready to merge. core Related to codefeedr-core. enhancement New feature or request labels Feb 19, 2019
@wzorgdrager
Copy link
Collaborator Author

wzorgdrager commented Feb 19, 2019

  • Write some integration tests (using pipelinebuilder instead of directly building a graph)
  • Think of more corner cases
  • Add more complex tests (with StageN objects).

Edge cases:

  • Do we care about input/transform stages which are not linked to any transform/output stage ? I.e. stages that write to buffer which is not read.
  • Do we care about completely isolated stages?

I would suggest adding warnings for those cases.

@wzorgdrager
Copy link
Collaborator Author

Enable graph verification by default!

@wzorgdrager wzorgdrager merged commit 5a56257 into develop Feb 20, 2019
@wzorgdrager wzorgdrager deleted the improvement/type_verification branch February 20, 2019 09:53
@wzorgdrager wzorgdrager removed the not ready This branch is not ready to merge. label Feb 20, 2019
@wzorgdrager wzorgdrager mentioned this pull request Feb 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Related to codefeedr-core. enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant