Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature signin signup #1

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

oyham
Copy link

@oyham oyham commented Dec 29, 2023

ES

Los cambios realizados se dan en formato mobile ya que el contenedor de los form se encontraba a la derecha del viewport, deformándose, y se perdía el título de 'codefend'.

Las implementaciones y cambios que realicé fueron:

  • colocar el contenedor del form en el centro y dando lugar para que el titulo 'codefend' sea visible.
  • añadir overflow-y al form para dimensiones que no puedan abarcar toda el height del form.
  • cambiar la clase mt-6 -> mt-2, y añadir mb-2 al último div del form para mejorar su visualización.

Revisar la carpeta screenshots para ver el antes y después.


EN

The changes made are in mobile format since the form container was positioned to the right of the viewport, causing deformation and resulting in the loss of the 'codefend' title.

The implementations and changes I made were:

  • centering the form container and making space for the 'codefend' title to be visible.
  • adding overflow-y to the form for dimensions that cannot cover the entire height of the form.
  • changing the class from mt-6 to mt-2 and adding mb-2 to the last div of the form to improve its visualization.

Review the screenshots folder where I compare the before and after.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant