add testcase for user signin context

app/controllers/dashboard_controller.rb

@@ -1,5 +1,6 @@
 class DashboardController < ApplicationController
-  def index
-    @revisions = Revision.order(date: :desc).limit(4)
+ def index
+   p current_user
+   @revisions = Revision.order(date: :desc).limit(4)
   end
 end

app/controllers/github_controller.rb

@@ -2,6 +2,7 @@
 
 class GithubController < ApplicationController
   skip_before_filter :verify_authenticity_token, only: :hook
+  skip_before_filter :authenticate_user!, only: :hook
   include ErrorHandle
   def index
   end

app/controllers/revisions_controller.rb

@@ -1,5 +1,6 @@
 class RevisionsController < ApplicationController
   include ErrorHandle
+  skip_before_action :authenticate_user!, only: [:show, :via_hash]
 
   # GET /revisions
   # GET /revisions.json

spec/controllers/dashboard_controller_spec.rb

@@ -1,31 +1,40 @@
 require 'spec_helper'
 
 describe DashboardController do
-
-  before do
-    user = User.create!
-    user.save
-    sign_in user
+  context "not sign-in" do
+    describe "GET 'index'" do
+      before { get 'index' }
+      subject { response }
+      it { should redirect_to(new_user_session_path) }
+    end
   end
 
-  describe "GET 'index'" do
+  context "user sign-in" do
     before do
-      @foo = create(:revision, hash_code: 'foo')
-      @bar = create(:revision, hash_code: 'bar')
-      @baz = create(:revision, hash_code: 'baz')
-      get 'index'
+      user = User.create!
+      user.save
+      sign_in user
     end
 
-    describe 'response' do
-      subject { response }
-      it { should be_success }
-    end
+    describe "GET 'index'" do
+      before do
+        @foo = create(:revision, hash_code: 'foo')
+        @bar = create(:revision, hash_code: 'bar')
+        @baz = create(:revision, hash_code: 'baz')
+        get 'index'
+      end
+
+      describe 'response' do
+        subject { response }
+        it { should be_success }
+      end
 
-    describe 'revisions' do
-      subject { assigns(:revisions) }
+      describe 'revisions' do
+        subject { assigns(:revisions) }
 
-      it { should_not be_empty }
-      it { should include(@foo,@bar,@baz) }
+        it { should_not be_empty }
+        it { should include(@foo,@bar,@baz) }
+      end
     end
   end
 end

spec/controllers/github_controller_spec.rb

@@ -2,72 +2,94 @@
 require 'ostruct'
 
 describe GithubController do
-  before do
-    user = User.create!
-    user.save
-    sign_in user
-  end
-
   def commit(hash_code, url, log)
     OpenStruct.new(hash_code: hash_code,
                    url: url,
                    log: log)
   end
 
   describe "GET 'index'" do
-    before do
-      get 'index'
-    end
-
-    describe 'response' do
+    context "not signin" do
+      before { get 'index' }
       subject { response }
-      it { should be_success }
+      it { should redirect_to(new_user_session_path) }
     end
-  end
 
-  describe "POST 'import'" do
-    context 'success' do
+    context "signin" do
       before do
-        create(:revision, hash_code: 'bar')
-
-        RevisionIt::Service::Github.
-          stub(:commits).
-          with('https://github.com/codefirst/revision-it').
-          and_yield(commit("foo", "http://example.com", "this is text")).
-          and_yield(commit("bar", "http://example.com", "this is text"))
+        user = User.create!
+        user.save
+        sign_in user
+      end
 
-        post 'import_all', url: 'https://github.com/codefirst/revision-it'
+      before do
+        get 'index'
       end
 
       describe 'response' do
         subject { response }
-        it { should redirect_to(github_path) }
+        it { should be_success }
       end
+    end
+  end
 
-      describe 'new revision' do
-        subject { Revision.where(hash_code: 'foo').first }
-        its(:log) { should == 'this is text' }
-        its(:url) { should == 'http://example.com' }
+  describe "POST 'import'" do
+    context "not signin" do
+      before { get 'index' }
+      subject { response }
+      it { should redirect_to(new_user_session_path) }
+    end
+
+    context "signin" do
+
+      before do
+        user = User.create!
+        user.save
+        sign_in user
       end
 
-      describe 'update revision' do
-        subject { Revision.where(hash_code: 'bar').first }
-        its(:log) { should == 'this is text' }
-        its(:url) { should == 'http://example.com' }
+      context 'success' do
+        before do
+          create(:revision, hash_code: 'bar')
+
+          RevisionIt::Service::Github.
+            stub(:commits).
+            with('https://github.com/codefirst/revision-it').
+            and_yield(commit("foo", "http://example.com", "this is text")).
+            and_yield(commit("bar", "http://example.com", "this is text"))
+
+          post 'import_all', url: 'https://github.com/codefirst/revision-it'
+        end
+
+        describe 'response' do
+          subject { response }
+          it { should redirect_to(github_path) }
+        end
+
+        describe 'new revision' do
+          subject { Revision.where(hash_code: 'foo').first }
+          its(:log) { should == 'this is text' }
+          its(:url) { should == 'http://example.com' }
+        end
+
+        describe 'update revision' do
+          subject { Revision.where(hash_code: 'bar').first }
+          its(:log) { should == 'this is text' }
+          its(:url) { should == 'http://example.com' }
+        end
       end
-    end
 
-    context 'error' do
-      describe 'invalid url' do
-        before {
-          post 'import_all', url: 'https://example.com'
-        }
+      context 'error' do
+        describe 'invalid url' do
+          before {
+            post 'import_all', url: 'https://example.com'
+          }
 
-        subject { response }
-        it { should_not be_success }
-        its(:status) { should == 400 }
+          subject { response }
+          it { should_not be_success }
+          its(:status) { should == 400 }
+        end
       end
-
     end
   end
 

spec/controllers/revision_controller_spec.rb

@@ -1,28 +1,36 @@
 require 'spec_helper'
 
 describe RevisionsController do
-  before do
-    user = User.create!
-    user.save
-    sign_in user
-  end
-
   describe "GET 'index'" do
-    before do
-      100.times {|i|
-        create(:revision, hash_code: "commit-#{i}")
-      }
-      get 'index'
-    end
-
-    describe 'response' do
+    context "not signin" do
+      before { get 'index' }
       subject { response }
-      it { should be_success }
+      it { should redirect_to(new_user_session_path) }
     end
 
-    describe 'assigns' do
-      subject { assigns :revisions }
-      it { should have(100).items }
+    context "signin" do
+      before do
+        user = User.create!
+        user.save
+        sign_in user
+      end
+
+      before do
+        100.times {|i|
+          create(:revision, hash_code: "commit-#{i}")
+        }
+        get 'index'
+      end
+
+      describe 'response' do
+        subject { response }
+        it { should be_success }
+      end
+
+      describe 'assigns' do
+        subject { assigns :revisions }
+        it { should have(100).items }
+      end
     end
   end
 

spec/controllers/welcome_controller_spec.rb

@@ -1,12 +1,27 @@
 require 'spec_helper'
 
 describe WelcomeController do
-
-  describe "GET 'index'" do
-    it "returns http success" do
-      get 'index'
-      response.should be_success
+  context "not sign in" do
+    describe "GET 'index'" do
+      it "returns http success" do
+        get 'index'
+        response.should be_success
+      end
     end
   end
 
+  context "user sign in" do
+    describe "GET 'index'" do
+      before do
+        user = User.create!
+        user.save
+        sign_in user
+      end
+
+      it "returns http success" do
+        get 'index'
+        response.should redirect_to(dashboard_path)
+      end
+    end
+  end
 end