Support for Contao 5.1+ #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aschempp
force-pushed
the
feature/contao5
branch
from
aa22bff
to
e278109
Compare
|
when its ready… 🤷 |
|
very well then 🙃 I removed the deprecated stuff and updated everything to using autowiring and attributes 😎 |
aschempp
force-pushed
the
feature/contao5
branch
2 times, most recently
from
38174fe
to
413c350
Compare
aschempp
force-pushed
the
feature/contao5
branch
from
413c350
to
6ac43a9
Compare
|
I think this is ready for release (RC or stable). I even added a new CI chain (see https://github.com/aschempp/contao-news_categories/actions) 😎 |
# Conflicts: # src/FrontendModule/CumulativeFilterModule.php # src/FrontendModule/CumulativeHierarchicalFilterModule.php
|
Released as 4.0.0. Thanks a lot @aschempp ! |
|
Thank you very much @aschempp for your great work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should update the extension for Contao 5.1 support (only). I initially tried to keep Contao 4.13 compatibility, but that's almost impossible with the new feed page types and a lot of compatibility breaks. Not sure if this would be a new major version since we dropped several classes. They are not really API, but it also wouldn't harm (maybe we could refactor some more stuff).
PS: still a draft since it's all brain dump and not fully tested yet (especially the feed stuff).