Errship Gem Not working

[ryanatwork]

Errship gem should display the correct error page when an error occurs but it's not happening

Example

If you load up http://brigade.codeforamerica.org/locations the 404 page should render but instead the default Rails 404 renders
If you go to http://brigade.codeforamerica.org/notfound then the correct 404 page shows

This also happens with 500 pages

http://brigade.codeforamerica.org/error
versus
http://brigade.codeforamerica.org/deployed_applications
Which renders the default Rails 500 page instead of the nice 500 page.

[mchung]

Due to a change in the way routing is handled in Rails 3.2, we may no longer depend on rescue_from AbstractController::ActionNotFOund to catch the exception and redirect to a 404.

The fix is to configure exceptions_app so that errors are also routed:

https://github.com/vidibus/vidibus-routing_error#alternative-one.

I can submit a patch later if this sounds good.

[kmcurry]

I'm not well qualified to decide. Any second opinions out there?

[rmcastil]

@mchung sure. can you submit a pull request and we'll check it out?

[kmcurry]

I'm not able to verify pull request #116 on localhost (or even issue #45). It could be a problem with my local server. When I point to /locations and /notfound I get responses like:

Routing Error

No route matches [GET] "/notfound"
Try running rake routes for more information on available routes.

[rmcastil]

@kmcurry Sorry I've been missing in action. Had a crazy holiday. Did you just close this pull request?

[kmcurry]

yep!

On Mon, Jan 7, 2013 at 9:22 AM, Ryan Castillo notifications@github.comwrote:

@kmcurry https://github.com/kmcurry Sorry I've been missing in action.
Had a crazy holiday. Did you just close this pull request?

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/45#issuecomment-11953095.

Kevin Curry
Program Director
CfA Brigade
757.613.8158
GMT-5
http://brigade.codeforamerica.org