Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding known translations #495

Merged
merged 3 commits into from
Feb 12, 2024
Merged

Adding known translations #495

merged 3 commits into from
Feb 12, 2024

Conversation

sree-cfa
Copy link
Contributor

@sree-cfa sree-cfa commented Jan 26, 2024 •
edited

From JR (translation service)

@sree-cfa sree-cfa changed the title Adding translations known translations Adding known translations Feb 5, 2024
@spokenbird spokenbird self-requested a review February 5, 2024 23:52
@sree-cfa sree-cfa marked this pull request as ready for review February 7, 2024 16:37
coltborg
coltborg approved these changes Feb 8, 2024
View reviewed changes
Copy link
Contributor

@coltborg coltborg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked as I expected locally with these starter app settings:

form-flow:
  languages: en, es, vi

2024-02-08 at 13 01 52@2x

@sree-cfa sree-cfa merged commit 1a086ee into main Feb 12, 2024
5 checks passed
@sree-cfa sree-cfa deleted the adding-translations branch February 12, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coltborg coltborg coltborg approved these changes

@spokenbird spokenbird Awaiting requested review from spokenbird

@bseeger bseeger Awaiting requested review from bseeger

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sree-cfa @coltborg