Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve radio fieldset #508

Merged
merged 4 commits into from
Feb 12, 2024
Merged

Improve radio fieldset #508

merged 4 commits into from
Feb 12, 2024

Conversation

guiburato
Copy link
Contributor

  • implement new optional param(radioHelpText) for radio input

@bseeger
Copy link
Contributor

bseeger commented Feb 12, 2024

Out of curiosity - the radioFieldset does have helptext - do you have a use case where you're not using a field set? Or a use case where there is helptext for each radio button?

I just want to understand the use case - no objection to doing this.

@sree-cfa
Copy link
Contributor

@bseeger checkboxInSet has this at the selection-level too. We want some additional text for a radio option
Screen Shot 2024-02-07 at 3 03 48 PM

Copy link
Contributor

@bseeger bseeger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sree-cfa sree-cfa merged commit 5022033 into main Feb 12, 2024
5 checks passed
@sree-cfa sree-cfa deleted the improve_radioFieldset branch February 12, 2024 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants