Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update readme for radio fragment #513

Merged
merged 2 commits into from
Feb 15, 2024
Merged

Update readme for radio fragment #513

merged 2 commits into from
Feb 15, 2024

Conversation

bseeger
Copy link
Contributor

@bseeger bseeger commented Feb 14, 2024

No description provided.

@@ -17,7 +16,9 @@ The library includes tooling for:
- Input Validations
- Using [JPA Validation](https://www.baeldung.com/spring-boot-bean-validation)
- Address Validation using [Smarty](https://smarty.com/)
- A set of [Thymeleaf fragments](https://github.com/codeforamerica/form-flow/tree/main/src/main/resources/templates/fragments) that create a library of reusable HTML components for Inputs, Screens, Forms, etc.
- A set
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So much of this is just intellij styling this. Not sure why it wasn't already styled correctly.

@Column(name = "url_params", columnDefinition = "jsonb")
private Map<String, String> urlParams;
@Type(JsonType.class)
@Column(name = "url_params", columnDefinition = "jsonb")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We did change from 2 - 4 spaces, so I'm guessing that's why this changed here.


#### Radio

Radio inputs are used to gather a single selection from a set of options. They are used in unison
with
a `radioFieldset` fragment to create a group of radio inputs that are all related to each other.
with a `radioFieldset` fragment to create a group of radio inputs that are all related to each
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is where my actual changes begin.

option fragment
as many times as you like to create the necessary number of radio options.
quickly create groupings of radio inputs. Not that when using this template, you can copy the inner
radio option fragment as many times as you like to create the necessary number of radio options.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My actual changes end here.

Copy link
Contributor

@spokenbird spokenbird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@spokenbird spokenbird merged commit 89cf9d1 into main Feb 15, 2024
5 checks passed
@spokenbird spokenbird deleted the update_radio_readme branch February 15, 2024 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants