Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding param to screens fragments 🍖 #518

Merged
merged 3 commits into from
Feb 22, 2024
Merged

Conversation

sree-cfa
Copy link
Contributor

@sree-cfa sree-cfa commented Feb 20, 2024

Description of change ✍️

Adding iconFragment to screens since there might be multiple icons files in other SNE apps

Priority 🥇

Medium - we can override these locally, but they'd be nice to have in the FFL

Effect on other applications using FFB 🌊

No breaking changes - this is adding a new param to a fragment, if it's null, it will not show up

✅ Checklist before requesting a review

*Didn't update docs/tests/readme since iconName doesn't explicitly have these either

  • Does the new code follow our preferred coding style?
  • Does the code include javadocs, where necessary?
  • Have tests for this feature been added / updated?
  • Has the readme been updated?

@sree-cfa sree-cfa changed the title Adding param to screens fragments Adding param to screens fragments 🍖 Feb 20, 2024
@sree-cfa sree-cfa self-assigned this Feb 20, 2024
@sree-cfa sree-cfa marked this pull request as ready for review February 20, 2024 23:33
@sree-cfa
Copy link
Contributor Author

TODO - update livetemplate

@coltborg coltborg self-requested a review February 22, 2024 21:05
sree-cfa and others added 3 commits February 22, 2024 16:25
Copy link
Contributor

@coltborg coltborg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed both fragments and they act the same. Also tested the updated live templates. Lgtm; :shipit:

@sree-cfa sree-cfa merged commit 5894b6e into main Feb 22, 2024
5 checks passed
@sree-cfa sree-cfa deleted the update-icons-in-screens branch February 22, 2024 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants