Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default value of show-stack-trace to false #521

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

coltborg
Copy link
Contributor

Description of change ✍️

When reviewing IL code using show-stack-trace I noticed that the library readme said that the default value is true, but the code has it set to false.

Priority 🥇

Low priority, only effects documentation.

Effect on other applications using FFB 🌊

None

Testing

None

✅ Checklist before requesting a review

  • Does the new code follow our preferred coding
    style
    ?
  • Does the code include javadocs, where necessary?
  • Has the readme been updated?

@coltborg coltborg self-assigned this Feb 22, 2024
Copy link
Contributor

@sree-cfa sree-cfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@coltborg coltborg merged commit f0b366e into main Feb 22, 2024
5 checks passed
@coltborg coltborg deleted the fix-show-stack-trace-readme branch February 22, 2024 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants