Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix date errors for component #527

Merged
merged 8 commits into from
Mar 6, 2024
Merged

Fix date errors for component #527

merged 8 commits into from
Mar 6, 2024

Conversation

sree-cfa
Copy link
Contributor

@sree-cfa sree-cfa commented Mar 5, 2024

Description of change ✍️

  • We want "form-group--error" if there is also an overall error for the date field
  • cleanup - arrays.isEmpty should also check for null

Priority 🥇

Medium - we can override the component in the meantime

Effect on other applications using FFB 🌊

  • TODO verify that this is backwards compatible

✅ Checklist before requesting a review

  • Does the new code follow our preferred coding
    style
    ?
  • Does the code include javadocs, where necessary?
  • Have tests for this feature been added / updated?
  • Has the readme been updated?

- We want "form-group--error" if there is also an overall error for the date field
- TODO verify that this is backwards compatible
- cleanup - arrays.isEmpty should also check for null
@sree-cfa sree-cfa self-assigned this Mar 5, 2024
@sree-cfa sree-cfa marked this pull request as ready for review March 5, 2024 02:55
@enyia21 enyia21 self-requested a review March 5, 2024 21:07
Copy link
Contributor

@enyia21 enyia21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be an explicit test for the date.html fragment. We should test both the error messages and that the form-group--error class is added appropriately to the group

@sree-cfa sree-cfa requested a review from enyia21 March 6, 2024 19:29
@sree-cfa sree-cfa merged commit d3d9a50 into main Mar 6, 2024
5 checks passed
@sree-cfa sree-cfa deleted the fix-date-error branch March 6, 2024 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants