Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Honeycrisp updates (Breaking) #529

Merged
merged 6 commits into from
Mar 7, 2024
Merged

Honeycrisp updates (Breaking) #529

merged 6 commits into from
Mar 7, 2024

Conversation

sree-cfa
Copy link
Contributor

@sree-cfa sree-cfa commented Mar 6, 2024

Description of change ✍️

Fixing "none of the above" checkboxes to be unique so that they don't affect the function of other check box sets on the same page
See codeforamerica/honeycrisp-gem#320

Reveal component accessibility
See codeforamerica/honeycrisp-gem#317

Priority 🥇

High - We're currently running into an issue w checkboxes in il-gcc and can't easily address it in the app itself.

Effect on other applications using FFB 🌊

Possibly breaking

  • this affects checkboxes with a "none of the above" option. If the checkbox fragment is overridden, then there may need to be an update to the id for "none__checkbox" to include the inputName --> "none__checkbox-inputName"
  • reveal component class changed from "reveal__link" to "reveal__button" - should be updated in SNE css classes as well

✅ Checklist before requesting a review

  • Does the new code follow our preferred coding
    style
    ?
  • Does the code include javadocs, where necessary?
  • Have tests for this feature been added / updated?
  • Has the readme been updated?

@sree-cfa sree-cfa self-assigned this Mar 6, 2024
@sree-cfa sree-cfa marked this pull request as ready for review March 6, 2024 20:01
@sree-cfa sree-cfa changed the title Fix none checkbox Honeycrisp updates Mar 7, 2024
@sree-cfa sree-cfa changed the title Honeycrisp updates Honeycrisp updates (Breaking) Mar 7, 2024
Copy link
Contributor

@spokenbird spokenbird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @sree-cfa !

@sree-cfa sree-cfa merged commit c7e4343 into main Mar 7, 2024
5 checks passed
@sree-cfa sree-cfa deleted the fix-none-checkbox branch March 7, 2024 22:50
@sree-cfa
Copy link
Contributor Author

sree-cfa commented Mar 8, 2024

Note: Associated honeycrisp sha codeforamerica/honeycrisp-gem@4d31037

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants