Fix error seen in validating uuid. #551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bseeger
commented
May 2, 2024
| @@ -63,6 +64,7 @@ public class ScreenController extends FormFlowController { | |||
|
|
|||
| public static final String FLOW = "/flow"; | |||
| public static final String FLOW_SCREEN_PATH = "{flow}/{screen}"; | |||
| private final String DELETE_CONFIRMATION_REDIRECT_UUID = "deleteConfirmationRedirectUuid"; | |||
There was a problem hiding this comment.
I'm going to take this out. It was for an intermediate impl attempt that we didn't end up using.
bseeger
force-pushed
the
fix_subflow_screen_in_subflow
branch
from
b442140
to
19c3969
Compare
bseeger
force-pushed
the
fix_subflow_screen_in_subflow
branch
from
474e7b6
to
e2c35cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue tracking number 🔗
Description of change ✍️
This fix relates to something missed when validating uuids. If a subflow iteration was already deleted and the user clicked "Go Back" the code didn't handle that well. This fixes how the code handles that scenario and adds a tests for that to catch regressions in the future.
Priority 🥇
Effect on other applications using FFB 🌊
Testing
✅ Checklist before requesting a review
style?