Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed spacing on text input groups #169

Merged
merged 2 commits into from
Feb 25, 2020
Merged

Conversation

SymonneSingleton
Copy link
Contributor

Co-authored-by: Symonne Singleton symonne@codeforamerica.org

- added example of postfix and prefix combinations
- fixes issue #144

Co-authored-by: Symonne Singleton <symonne@codeforamerica.org>
@hartsick hartsick temporarily deployed to honeycrisp-text-input-g-eolxio January 30, 2020 22:52 Inactive
Copy link
Contributor

@racheledelman racheledelman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

The top inner shadow is missing on the editable parts of the inputs. Observed on iOS Chrome and iOS Safari (fine on desktop versions of both). Otherwise, looks good.

@SymonneSingleton
Copy link
Contributor Author

i see, good catch! I have some work for cmr to do, but can return to this story when time opens up. If anyone else wants to pick it up and needs context, happy to help.

@SymonneSingleton
Copy link
Contributor Author

SymonneSingleton commented Feb 25, 2020

@racheledelman I'm having trouble replicating this issue. What steps did you take to get this view? It looks like this on my end:
Screen Shot 2020-02-25 at 11 07 01 AM

sorry i cut off the edges, but still

@racheledelman
Copy link
Contributor

We discussed, and this only shows up on iOS, not the emulator.

@hartsick hartsick temporarily deployed to honeycrisp-text-input-g-eolxio February 25, 2020 19:20 Inactive
@SymonneSingleton SymonneSingleton merged commit 9d6c037 into master Feb 25, 2020
@lkogler lkogler deleted the text-input-group-spacing branch May 21, 2020 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants