Add pilot-offboard screen #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bseeger
reviewed
Jan 31, 2024
| @@ -1,6 +1,9 @@ | |||
| name: gcc | |||
| flow: | |||
| onboarding-getting-started: | |||
There was a problem hiding this comment.
Hi! Just passing through. Out of curiosity - why are you changing the pattern of page name from camel case to hyphenated?
There was a problem hiding this comment.
We agreed to align screen names with design screen names. I guess I could change the kebab case into camel case if I wanted to.
There was a problem hiding this comment.
I don't see any problems with aligning screen names with the design screen names. The page renders correctly.
There was a problem hiding this comment.
Ah, okay, that makes sense. I didn't know if there was a change in philosophy regarding this. Like I said, just curious.
enyia21
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#186713028
This PR only adds the
pilot-offboardscreen.