Ccap 115 primary parent working hours #271
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
rapicastillo
requested review from
coltborg,
rapicastillo and
enyia21
and removed request for
rapicastillo and
coltborg
There was a problem hiding this comment.
This class feels more like a utility to me and fits better in utils package?
There was a problem hiding this comment.
Would it be better to call it ScheduleUtilities for consistency?
There was a problem hiding this comment.
Sounds good! I called it SchedulePreparerUtilities so that it is clear where it is being used.
There was a problem hiding this comment.
Really nice refactoring, I think! cleans up the code a lot and makes sense to move things in a more logical util setup. :)
I posed a suggestion on where to put SchedulePreparer and maybe rename it to ScheduleUtilities just mainly for consistency on utilities, but I'd defer to the rest of the team who has done more work on the code.
There was a problem hiding this comment.
Would it be better to call it ScheduleUtilities for consistency?
analoo
force-pushed
the
CCAP-115-primary-parent-working-hours
branch
from
546ae43
to
5bab344
Compare
🔗 Jira ticket
✍️ Description
📷 Design reference
✅ Completion tasks