All Expenses #375
Merged
All Expenses #375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
analoo
commented
Oct 19, 2023
| @@ -9,7 +9,7 @@ | |||
| <div class="grid"> | |||
| <div th:replace="~{fragments/goBack :: goBackLink}"></div> | |||
| <main id="content" role="main" class="form-card spacing-above-35"> | |||
| <p class="employer-name" th:text="${fieldData.get('employerName')}"></p> | |||
| <p class="grey-text" th:text="${fieldData.get('employerName')}"></p> | |||
There was a problem hiding this comment.
fyi @lkemperman-cfa - changed the class to be more universal than employer name.
analoo
commented
Oct 19, 2023
| expensesHome: | ||
| nextScreens: | ||
| - name: expensesRent | ||
| condition: ExpensesIncludeRent |
There was a problem hiding this comment.
@sree-cfa @lkemperman-cfa - I don't love this approach. Is there a better way?
There was a problem hiding this comment.
Yeah, I dont think there's a better way atm. The only thing I can think of is extracting some of the duplicate code into a super conditional class so that each condition just has to pass the corresponding value
There was a problem hiding this comment.
Ex.
return super.run(submission, "Rent")
added 9 commits
October 25, 2023 15:14
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.