La digital Assister file upload with type #383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sree-cfa should we keep this around for now, or just close it? |
bseeger
changed the title
bseeger
changed the title
Yeah, we can close it - We'll still have it to reference if we want to do it at some point |
|
Closing as we are holding off on this for now. Noting that the PR that relates to this in FF has been merged. |
bseeger
reviewed
Dec 15, 2023
src/main/java/org/ladocuploader/app/utils/UserFileUtilities.java
Outdated
Show resolved
Hide resolved
sree-cfa
reviewed
Dec 15, 2023
| BIRTH_CERTIFICATE ("BirthCertificate", "add-document-types.doc-type-label.permanent-documents.birth-certificate"), | ||
| DRIVERS_LICENSE("DriversLicense", "add-document-types.doc-type-label.permanent-documents.drivers-license"), | ||
| SOCIAL_SECURITY_CARD("SocialSecurityCard", "add-document-types.doc-type-label.permanent-documents.social-security-card"), | ||
| CHECK_STUP("CheckStub", "add-document-types.doc-type-label.income.check-stub"), |
There was a problem hiding this comment.
Should be CHECK_STUB with w a "B"?
bseeger
reviewed
Dec 15, 2023
src/main/java/org/ladocuploader/app/submission/conditions/AddDocumentsSelected.java
Outdated
Show resolved
Hide resolved
bseeger
reviewed
Dec 15, 2023
src/main/java/org/ladocuploader/app/utils/UserFileUtilities.java
Outdated
Show resolved
Hide resolved
sree-cfa
reviewed
Dec 15, 2023
src/main/resources/db/migration/V2023.10.25.08.58.36__update_doc_type_label_default.sql
Outdated
Show resolved
Hide resolved
sree-cfa
reviewed
Dec 15, 2023
sree-cfa
reviewed
Dec 15, 2023
src/main/java/org/ladocuploader/app/submission/actions/AssociateDocTypeLabel.java
Show resolved
Hide resolved
sree-cfa
reviewed
Dec 15, 2023
sree-cfa
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for updating
user_fileswith document file types in an action through using a special dynamic field, which is supported by the validation service in the form-flow library. Also adds screens for associating the file type from a list offile_typesfor each added file, reviewing types, and going back to add/ remove as necessary.Dependent on merging this pr from form-flow library, which adds the migration and validation behavior we need.