Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates fragments based on moving a few things into the FFB library. #400

Merged
merged 4 commits into from Dec 15, 2023
Merged

Updates fragments based on moving a few things into the FFB library. #400

merged 4 commits into from Dec 15, 2023

Conversation

bseeger
Copy link
Contributor

@bseeger bseeger commented Nov 6, 2023 •
edited

@sree-cfa sree-cfa temporarily deployed to test-la-doc-uploader-pr-400 November 6, 2023 18:38 Inactive
@sree-cfa sree-cfa temporarily deployed to test-la-doc-uploader-pr-400 November 6, 2023 18:42 Inactive
@sree-cfa sree-cfa temporarily deployed to test-la-doc-uploader-pr-400 November 6, 2023 19:10 Inactive
@bseeger
Copy link
Contributor Author

bseeger commented Nov 7, 2023

I think this will fail until the FFB library merges the related PR for this.

@bseeger bseeger force-pushed the remove_unneeded_fragments branch 2 times, most recently from 792c90e to 81b8cb2 Compare December 13, 2023 20:51
@bseeger bseeger closed this Dec 14, 2023
@bseeger bseeger reopened this Dec 14, 2023
@sree-cfa sree-cfa temporarily deployed to test-la-doc-uploader-pr-400 December 14, 2023 13:33 Inactive
sree-cfa
sree-cfa approved these changes Dec 14, 2023
View reviewed changes
Copy link
Contributor

@sree-cfa sree-cfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sree-cfa sree-cfa temporarily deployed to test-la-doc-uploader-pr-400 December 15, 2023 17:41 Inactive
@bseeger bseeger merged commit 2ff6975 into main Dec 15, 2023
5 checks passed
@bseeger bseeger deleted the remove_unneeded_fragments branch December 15, 2023 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sree-cfa sree-cfa sree-cfa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@bseeger @sree-cfa