action tests #441
Merged
action tests #441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bseeger
reviewed
Dec 12, 2023
| FormSubmission form = new FormSubmission(Map.of( | ||
| "phoneNumber", "1234561234", | ||
| "emailAddress", BLANK_VALUE, | ||
| "remindersMethod[]", new ArrayList<>(List.of(PHONE_REMINDER)) |
There was a problem hiding this comment.
I think you can just say "List.of(PHONE_REMINDER)" rather than passing that into the new ArrayList<>()
"remindersMethod[]", List.of(PHONE_REMINDER)
There was a problem hiding this comment.
There are a few other spots where you do this, but I won't make a comment at each one.
There was a problem hiding this comment.
We were running into an issue when just passing List.of because it's immutable
There was a problem hiding this comment.
+1 just confirmed that we see the immutable issue when trying to pass just the List.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-Authored-By: @sree-cfa