Implement experiment sorting #444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Luigi <luigi@codeforamerica.org>
sree-cfa
reviewed
Dec 14, 2023
| switch(group) { | ||
| case 0 -> submission.getInputData().put("experimentGroup", ExperimentGroup.CONTROL); | ||
| case 1 -> submission.getInputData().put("experimentGroup", ExperimentGroup.LINK); | ||
| case 2 -> submission.getInputData().put("experimentGroup", ExperimentGroup.APPLY); |
There was a problem hiding this comment.
Do enums get saved as strings in the db? If there's some conversion needed, might be nice to have a helper method in the enum class Actually I think valueOf will take care of that
There was a problem hiding this comment.
Looks like they are automatically converted to strings. Here is how they look in the JSON:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a beforeSaveAction
SetExperimentGroupsthat runs on the first post in the digital assister flow (the Language Preferences page). TheSetExperimentGroupsaction uses an enum with values CONTROL, LINK and, APPLY along with a simple algorithm that randomly assigns one of the three enum values.The assigned value is stored in the Submissions input data JSON as
experimentGroup.