Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for verification documents to transmission and remove required CSV fields #455

Merged
merged 20 commits into from
Dec 20, 2023

Conversation

lkemperman-cfa
Copy link
Contributor

No description provided.

@lkemperman-cfa lkemperman-cfa marked this pull request as draft December 18, 2023 16:16
@sree-cfa sree-cfa temporarily deployed to test-la-doc-uploader-pr-455 December 18, 2023 16:16 Inactive
@lkemperman-cfa lkemperman-cfa temporarily deployed to test-la-doc-uploader-pr-455 December 18, 2023 16:39 Inactive
@lkemperman-cfa lkemperman-cfa temporarily deployed to test-la-doc-uploader-pr-455 December 18, 2023 22:48 Inactive
CloudFile docFile = fileRepository.download(userFile.getRepositoryPath());
byte[] bytes = new byte[Math.toIntExact(docFile.getFilesize())];
try (FileInputStream fis = new FileInputStream(docFile.getFile())) {
fis.read(bytes);

Check notice

Code scanning / CodeQL

Ignored error status of call Note

Method accept ignores exceptional return value of InputStream.read.
@lkemperman-cfa lkemperman-cfa temporarily deployed to test-la-doc-uploader-pr-455 December 18, 2023 22:54 Inactive
@lkemperman-cfa lkemperman-cfa temporarily deployed to test-la-doc-uploader-pr-455 December 19, 2023 16:53 Inactive
@lkemperman-cfa lkemperman-cfa temporarily deployed to test-la-doc-uploader-pr-455 December 19, 2023 16:56 Inactive
@lkemperman-cfa lkemperman-cfa force-pushed the verification-document-transmission branch from 93c52c8 to 22b3089 Compare December 19, 2023 21:04
@lkemperman-cfa lkemperman-cfa temporarily deployed to test-la-doc-uploader-pr-455 December 19, 2023 21:04 Inactive
@lkemperman-cfa lkemperman-cfa temporarily deployed to test-la-doc-uploader-pr-455 December 19, 2023 21:15 Inactive
@lkemperman-cfa lkemperman-cfa temporarily deployed to test-la-doc-uploader-pr-455 December 19, 2023 21:23 Inactive
@lkemperman-cfa lkemperman-cfa temporarily deployed to test-la-doc-uploader-pr-455 December 20, 2023 16:08 Inactive
@lkemperman-cfa lkemperman-cfa temporarily deployed to test-la-doc-uploader-pr-455 December 20, 2023 16:08 Inactive
@lkemperman-cfa lkemperman-cfa temporarily deployed to test-la-doc-uploader-pr-455 December 20, 2023 16:35 Inactive
@lkemperman-cfa lkemperman-cfa temporarily deployed to test-la-doc-uploader-pr-455 December 20, 2023 17:21 Inactive
@lkemperman-cfa lkemperman-cfa temporarily deployed to test-la-doc-uploader-pr-455 December 20, 2023 19:18 Inactive
@lkemperman-cfa lkemperman-cfa temporarily deployed to test-la-doc-uploader-pr-455 December 20, 2023 19:20 Inactive
@lkemperman-cfa lkemperman-cfa marked this pull request as ready for review December 20, 2023 21:00
@lkemperman-cfa lkemperman-cfa temporarily deployed to test-la-doc-uploader-pr-455 December 20, 2023 21:00 Inactive
@lkemperman-cfa lkemperman-cfa temporarily deployed to test-la-doc-uploader-pr-455 December 20, 2023 21:07 Inactive
@lkemperman-cfa lkemperman-cfa temporarily deployed to test-la-doc-uploader-pr-455 December 20, 2023 21:08 Inactive
@lkemperman-cfa lkemperman-cfa changed the title add support for verification documents to transmission add support for verification documents to transmission and remove required CSV fields Dec 20, 2023
Copy link
Contributor

@sree-cfa sree-cfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly would like to check if we can use FFB CloudRepository classes otherwise LGTM

@lkemperman-cfa lkemperman-cfa temporarily deployed to test-la-doc-uploader-pr-455 December 20, 2023 22:07 Inactive
when(csvService.generateCsvPackage(any(), any())).thenReturn(ecePackage);

File docFile = new File("paystub.png");
docFile.createNewFile();

Check notice

Code scanning / CodeQL

Ignored error status of call Note

Method transmitZipFile ignores exceptional return value of File.createNewFile.
@lkemperman-cfa lkemperman-cfa temporarily deployed to test-la-doc-uploader-pr-455 December 20, 2023 22:18 Inactive
@lkemperman-cfa lkemperman-cfa merged commit c211a57 into main Dec 20, 2023
5 checks passed
@lkemperman-cfa lkemperman-cfa deleted the verification-document-transmission branch December 20, 2023 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants