generated from codeforamerica/form-flow-starter-app
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for verification documents to transmission and remove required CSV fields #455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CloudFile docFile = fileRepository.download(userFile.getRepositoryPath()); | ||
byte[] bytes = new byte[Math.toIntExact(docFile.getFilesize())]; | ||
try (FileInputStream fis = new FileInputStream(docFile.getFile())) { | ||
fis.read(bytes); |
Check notice
Code scanning / CodeQL
Ignored error status of call Note
Method accept ignores exceptional return value of InputStream.read.
lkemperman-cfa
force-pushed
the
verification-document-transmission
branch
from
December 19, 2023 21:04
93c52c8
to
22b3089
Compare
…cumentation submissions
…ub to check the zip file contents
lkemperman-cfa
changed the title
add support for verification documents to transmission
add support for verification documents to transmission and remove required CSV fields
Dec 20, 2023
sree-cfa
reviewed
Dec 20, 2023
src/main/java/org/ladocuploader/app/upload/S3ReadOnlyCloudFileRepository.java
Outdated
Show resolved
Hide resolved
sree-cfa
reviewed
Dec 20, 2023
src/main/java/org/ladocuploader/app/cli/TransmitterCommands.java
Outdated
Show resolved
Hide resolved
sree-cfa
approved these changes
Dec 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly would like to check if we can use FFB CloudRepository classes otherwise LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.