Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIC/ECE Treatment 2 - apply #460

Merged
merged 3 commits into from Dec 20, 2023
Merged

WIC/ECE Treatment 2 - apply #460

merged 3 commits into from Dec 20, 2023

Conversation

sree-cfa
Copy link
Contributor

No description provided.

@sree-cfa sree-cfa temporarily deployed to test-la-doc-uploader-pr-460 December 19, 2023 01:50 Inactive
@sree-cfa sree-cfa temporarily deployed to test-la-doc-uploader-pr-460 December 19, 2023 02:02 Inactive
@sree-cfa sree-cfa marked this pull request as ready for review December 19, 2023 02:04
@sree-cfa sree-cfa added the ready for review This PR is ready for code-review label Dec 19, 2023
@sree-cfa sree-cfa temporarily deployed to test-la-doc-uploader-pr-460 December 19, 2023 19:41 Inactive
Copy link
Contributor

@analoo analoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Did not do a QA.

@@ -19,6 +19,8 @@ general.check-all-that-apply=Check all that apply.
general.you=(You)
general.none-of-the-above=None of the above
general.good-news=Good news!
general.i-dont-know=I don't know
general.not-interested=No, I\u2019m not interested
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious why line 22 uses an apostrophe and line 23 uses unicode

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sometimes Figma c/p has a unicode apostrophe 🤷

nola-ece-links.title=ECE link
nola-ece-links.if-youre-approved=If you\u2019re approved for SNAP, you\u2019re also eligible for free childcare and pre-K.
nola-ece-links.subheader=These programs can:<ul class="list--bulleted"> <li>Provide free childcare and education for children from birth through age 4</li> <li>Provide free pre-K in public or private school for 4-year-olds</li></ul>
nola-ece.if-youre-approved=If you\u2019re approved for SNAP, you\u2019re also eligible for free childcare and pre-K.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again here with the unicode

@@ -653,6 +653,15 @@ void fullDigitalAssisterFlow() {
testPage.clickButton("Yes");
assertThat(testPage.getTitle()).isEqualTo("WIC link");
testPage.clickButton("Yes");
} else if ("ECE apply".equals(title)) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So cool! I didn't realize we could add else statements in the testing flow.

@sree-cfa sree-cfa merged commit 01a35fe into main Dec 20, 2023
5 checks passed
@sree-cfa sree-cfa deleted the treatment-apply branch December 20, 2023 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review This PR is ready for code-review
Projects
None yet
2 participants