Implement expedited SNAP screens #464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spokenbird
force-pushed
the
expedited-snap-screens
branch
from
e1546d6
to
841f390
Compare
sree-cfa
approved these changes
Jan 3, 2024
There was a problem hiding this comment.
lgtm - testing coverage is great.
Some observations/suggestions:
- The checks for "isApplyingForExpeditedSnap" could be a static method in submissionUtils - Then the conditional wouldnt need to be autowired. It also doesnt have to be autowired since theres nothing that condition needs to be initialized with.
- I think we could use Float or Double instead of BigDecimal since these values will be pretty small and we just need them for comparisons - the "<,>" operands can be used with primitives which might make it slightly more clear than "compareTo".
sree-cfa
force-pushed
the
expedited-snap-screens
branch
from
68b90e0
to
c02d295
Compare
sree-cfa
force-pushed
the
expedited-snap-screens
branch
from
24c1f74
to
cdf9c20
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.