Replace expenses multi questions for dynamic #466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
analoo
force-pushed
the
replace-expenses-multi-questions-for-dynamic
branch
from
4feeeda
to
15e2811
Compare
analoo
force-pushed
the
replace-expenses-multi-questions-for-dynamic
branch
from
15e2811
to
b3b3242
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
src/main/java/org/ladocuploader/app/submission/conditions/BasicArrayCondition.java
Fixed
Show fixed
Hide fixed
sree-cfa
reviewed
Dec 20, 2023
| <div class="form-card__content"> | ||
| <div th:each="expense, iter:${inputData.get('householdUtilitiesExpenses[]')}" | ||
| class="spacing-below-15"> | ||
| <div th:if="${expense != 'Other'}"> |
There was a problem hiding this comment.
It seems like we should keep this in since there's a field for this in the PDF - was there a reason for leaving it out?
There was a problem hiding this comment.
@sree-cfa - the design says to ask the amount question for all expeneses except other:
I can add it back in.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses Dynamic Fields to collect expenses data based on the expenses that a user has shared.
There are two key fields: 1) The array that stores all of the expenses selected by the user. 2) The Dynamic field and validations that will be the blueprint for additional fields that are created.
A new BasicArrayCondition checks that the data in the first key field requires a follow up question (collection of amounts).
As you can see, this change will delete A LOT of lines of code. It will reduce the cost of updating the multi select values because it means we do not need to create unique pages or unique validation.
Thanks to @bseeger and @lkemperman-cfa for creating Dynamic fields!!