Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to additional screens #468

Merged
merged 2 commits into from Dec 21, 2023
Merged

Updates to additional screens #468

merged 2 commits into from Dec 21, 2023

Conversation

analoo
Copy link
Contributor

@analoo analoo commented Dec 20, 2023

No description provided.

@sree-cfa sree-cfa temporarily deployed to test-la-doc-uploader-pr-468 December 20, 2023 22:22 Inactive
@analoo analoo added the WaitingOnDesignFeedback Waiting on Design Feedback label Dec 20, 2023
@sree-cfa sree-cfa temporarily deployed to test-la-doc-uploader-pr-468 December 21, 2023 01:04 Inactive
@analoo analoo closed this Dec 21, 2023
@analoo analoo force-pushed the updates-to-additional-screens branch from 5bca998 to 6b43423 Compare December 21, 2023 01:18
@analoo analoo reopened this Dec 21, 2023
@sree-cfa sree-cfa temporarily deployed to test-la-doc-uploader-pr-468 December 21, 2023 01:20 Inactive
@sree-cfa sree-cfa temporarily deployed to test-la-doc-uploader-pr-468 December 21, 2023 17:30 Inactive
@sree-cfa sree-cfa temporarily deployed to test-la-doc-uploader-pr-471 December 21, 2023 17:37 Inactive
@analoo analoo added ready for review This PR is ready for code-review and removed WaitingOnDesignFeedback Waiting on Design Feedback labels Dec 21, 2023
<body>
<div class="page-wrapper">
<div th:replace="~{fragments/toolbar :: toolbar}"></div>
<div th:replace="fragments/toolbar :: toolbar"></div>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just fyi - the ~{ } notation is preferred

Copy link
Contributor

@sree-cfa sree-cfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@analoo analoo merged commit 4e5be85 into main Dec 21, 2023
9 checks passed
@analoo analoo deleted the updates-to-additional-screens branch December 21, 2023 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review This PR is ready for code-review
Projects
None yet
2 participants