Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

finalized household pages and updated fragment syntax #484

Merged
merged 7 commits into from Jan 8, 2024

Conversation

analoo
Copy link
Contributor

@analoo analoo commented Dec 22, 2023

No description provided.

@sree-cfa sree-cfa temporarily deployed to test-la-doc-uploader-pr-484 December 22, 2023 23:35 Inactive
@analoo analoo added the ready for review This PR is ready for code-review label Dec 23, 2023
@lkemperman-cfa lkemperman-cfa temporarily deployed to test-la-doc-uploader-pr-484 January 3, 2024 15:53 Inactive
@analoo analoo removed the ready for review This PR is ready for code-review label Jan 4, 2024
@analoo analoo force-pushed the update-expenses-section-new-designs branch from d54a805 to e25733a Compare January 4, 2024 23:16
@sree-cfa sree-cfa temporarily deployed to test-la-doc-uploader-pr-484 January 4, 2024 23:16 Inactive
@sree-cfa sree-cfa temporarily deployed to test-la-doc-uploader-pr-484 January 5, 2024 17:34 Inactive
@analoo analoo added ready for review This PR is ready for code-review InPM/DesignReview and removed InPM/DesignReview labels Jan 5, 2024
@sree-cfa
Copy link
Contributor

sree-cfa commented Jan 8, 2024

Looks like household expenses arent getting mapped to the pdf
Screen Shot 2024-01-08 at 8 49 53 AM

@sree-cfa sree-cfa temporarily deployed to test-la-doc-uploader-pr-484 January 8, 2024 17:40 Inactive
@sree-cfa sree-cfa temporarily deployed to test-la-doc-uploader-pr-484 January 8, 2024 21:09 Inactive
@analoo analoo force-pushed the update-expenses-section-new-designs branch from b8e4741 to 2e0b0b3 Compare January 8, 2024 21:18
@sree-cfa sree-cfa temporarily deployed to test-la-doc-uploader-pr-484 January 8, 2024 21:18 Inactive
Copy link
Contributor

@sree-cfa sree-cfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@analoo analoo merged commit bccf1b9 into main Jan 8, 2024
5 checks passed
@analoo analoo deleted the update-expenses-section-new-designs branch January 8, 2024 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review This PR is ready for code-review
Projects
None yet
3 participants