Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated the household personal situations page #491

Merged
merged 3 commits into from
Jan 9, 2024

Conversation

analoo
Copy link
Contributor

@analoo analoo commented Jan 3, 2024

No description provided.

@sree-cfa sree-cfa temporarily deployed to test-la-doc-uploader-pr-491 January 3, 2024 18:35 Inactive
@sree-cfa sree-cfa temporarily deployed to test-la-doc-uploader-pr-491 January 3, 2024 22:42 Inactive
@analoo analoo added the ready for review This PR is ready for code-review label Jan 4, 2024
@sree-cfa sree-cfa temporarily deployed to test-la-doc-uploader-pr-491 January 4, 2024 19:22 Inactive
@bseeger
Copy link
Contributor

bseeger commented Jan 4, 2024

This looks good. My only question is about how we handle the applicant's data. In the race/ethnicity PR I handled it separately, so it shows up in the data as raceSelection and ethnicitySelection. This PR has it as a dynamic field and has wildcard in the field name. I don't know if we want to do it one way or another, but we should probably standardize on which way we handle the applicant vs family members.

@analoo analoo added InPM/DesignReview and removed ready for review This PR is ready for code-review labels Jan 5, 2024
@analoo analoo merged commit 24c8a08 into main Jan 9, 2024
5 checks passed
@analoo analoo deleted the personal-situations-refactoring branch January 9, 2024 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants