Adding chron job for snap application transmission #496
Conversation
sree-cfa
commented
Jan 5, 2024
•
sree-cfa
commented
- Added hourly cronjob for SNAP app transmission
- Clean up, logging for SNAP transmission
| public void transferSubmissions() { | ||
| // Get submissions to transfer | ||
| String batchSeq = Long.toString(transmissionRepository.nextValueBatchSequence()); | ||
| String batchIndex = Strings.padStart(batchSeq, BATCH_INDEX_LEN, '0'); | ||
| UUID uuid = UUID.randomUUID(); |
There was a problem hiding this comment.
Saw this and it made me curious about UUID collisions. Quick research suggest that it is extremely improbable and therefore unlikely.
There was a problem hiding this comment.
Yeah - unlikely and also ok if theres collisions, ideally I'd like to track "batchIndex" in the "run_id" column, but since it's restricted to UUID, Im just generating a new one here and logging the batchIndex+runId
|
|
||
| transmission.setDocumentationErrors(Map.of("error", e.getMessage())); | ||
| transmission.setStatus(TransmissionStatus.Failed); | ||
| updateTransmission(uuid, transmission); |
There was a problem hiding this comment.
@sree-cfa - curious if it's worthwhile including the subfolder details to hone in on what might cause the error.
I realize that the whole transmission would fail but I am curious if we will ever end up with big enough transmissions that it might become difficult to troubleshoot.
There was a problem hiding this comment.
Oh, yeah good call out - will add that
| String day = (String) inputData.get("birthDay"); | ||
| String month = (String) inputData.get("birthMonth"); | ||
| String year = (String) inputData.get("birthYear"); | ||
| String day = (String) inputData.getOrDefault("birthDay", ""); |
There was a problem hiding this comment.
I am surprised that we need a default for birthday since it is a required field. Wondering if this allows partial applications to be submitted (if there is a split session issue for example). 🤔
There was a problem hiding this comment.
Yeah - unlikely it will be null, but just added it as a safeguard
