Limiting transmission batches to 25 #512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
analoo
reviewed
Jan 12, 2024
|
|
||
| # Run every hour | ||
| # @hourly java -Dserver.port=9191 -jar /opt/la-doc-uploader/app.jar transferSubmissions | ||
| @hourly java -Dserver.port=9191 -jar /opt/form-flow-starter-app/app.jar transferSubmissions |
There was a problem hiding this comment.
@sree-cfa - curious: why is this referencing the form-flow starter app instead of the la-doc-uploader?
There was a problem hiding this comment.
This is just the path we've been using in the Dockerfile - the "MKDIR" part
spokenbird
reviewed
Jan 12, 2024
|
|
||
| queuedSubmissions = queuedSubmissions.stream() | ||
| .filter(submission -> (submission.getSubmittedAt().isBefore(submittedAtCutoff))).toList(); | ||
| log.info("Excluding %s submitted within last 2 hours".formatted(queuedSubmissions.size())); |
There was a problem hiding this comment.
For this log wouldn't queued submissions size be the number of applications that are in the window where they should be sent (as they are older than 2 hours ago?).
There was a problem hiding this comment.
Oh yeah youre right
spokenbird
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.