Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snap expedited application #547

Merged
merged 3 commits into from
Jan 24, 2024
Merged

Snap expedited application #547

merged 3 commits into from
Jan 24, 2024

Conversation

analoo
Copy link
Contributor

@analoo analoo commented Jan 22, 2024

No description provided.

@sree-cfa sree-cfa temporarily deployed to test-la-doc-uploader-pr-547 January 22, 2024 21:44 Inactive
@sree-cfa sree-cfa temporarily deployed to test-la-doc-uploader-pr-547 January 24, 2024 17:51 Inactive
@analoo analoo added the ready for review This PR is ready for code-review label Jan 24, 2024
Comment on lines 33 to 34
boolean hasHouseholdExpenses = utilities.get("expenses");
boolean hasHeatingExpenses = utilities.get("acOrCooling");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be slightly more readable to separate these into their own methods that return just the boolean

boolean hasHouseholdExpenses = hasHouseholdExpenses(submission);
boolean hasHeatingExpenses = hasHeatingExpenses(submission);

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea! Will work on this

@sree-cfa sree-cfa temporarily deployed to test-la-doc-uploader-pr-547 January 24, 2024 21:55 Inactive
Copy link
Contributor

@sree-cfa sree-cfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@analoo analoo merged commit 3296f61 into main Jan 24, 2024
5 checks passed
@analoo analoo deleted the expedited-snap-2 branch January 24, 2024 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review This PR is ready for code-review
Projects
None yet
3 participants