-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Snap expedited application #547
Conversation
src/main/java/org/ladocuploader/app/preparers/ExpeditedSnapPreparer.java
Fixed
Show resolved
Hide resolved
src/main/java/org/ladocuploader/app/preparers/ExpeditedSnapPreparer.java
Fixed
Show resolved
Hide resolved
src/main/java/org/ladocuploader/app/preparers/ExpeditedSnapPreparer.java
Fixed
Show fixed
Hide fixed
src/main/java/org/ladocuploader/app/preparers/ExpeditedSnapPreparer.java
Fixed
Show fixed
Hide fixed
src/main/java/org/ladocuploader/app/preparers/ExpeditedSnapPreparer.java
Fixed
Show resolved
Hide resolved
src/main/java/org/ladocuploader/app/preparers/ExpeditedSnapPreparer.java
Fixed
Show fixed
Hide fixed
src/main/java/org/ladocuploader/app/preparers/ExpeditedSnapPreparer.java
Fixed
Show fixed
Hide fixed
src/main/java/org/ladocuploader/app/preparers/ExpeditedSnapPreparer.java
Fixed
Show fixed
Hide fixed
src/main/java/org/ladocuploader/app/preparers/ExpeditedSnapPreparer.java
Fixed
Show fixed
Hide fixed
boolean hasHouseholdExpenses = utilities.get("expenses"); | ||
boolean hasHeatingExpenses = utilities.get("acOrCooling"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could be slightly more readable to separate these into their own methods that return just the boolean
boolean hasHouseholdExpenses = hasHouseholdExpenses(submission);
boolean hasHeatingExpenses = hasHeatingExpenses(submission);
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great idea! Will work on this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
No description provided.