Spanish translations from catalina 01 29 24 #578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
analoo
commented
Jan 30, 2024
| @@ -22,7 +22,7 @@ | |||
| content=~{::householdMembers})}"> | |||
| <th:block th:ref="householdMembers"> | |||
| <th:block | |||
| th:replace="~{fragments/inputs/radio :: radio(inputName=${inputName},value='you', label=${inputData.firstName + ' ' + inputData.lastName + ' (you) '})}"/> | |||
| th:replace="~{fragments/inputs/radio :: radio(inputName=${inputName},value='you', label=${inputData.firstName + ' ' + inputData.lastName + ' ' + #messages.msg('general.you')})}"/> | |||
There was a problem hiding this comment.
This was causing issues with the spanish translation since the text always appeared as "(you)"
analoo
commented
Jan 30, 2024
| @@ -12,7 +12,7 @@ | |||
| <main id="content" role="main" class="form-card spacing-above-35"> | |||
| <p class="grey-text" th:text="${fieldData.get('employerName')}"></p> | |||
| <th:block | |||
| th:replace="~{fragments/cardHeader :: cardHeader(header=${messageVariant == 'self' ? #messages.msgWithParams('self-employment.header', 'your') : #messages.msgWithParams('self-employment.header', fieldData.get('householdMemberJobAdd') + '''s')})}"/> | |||
| th:replace="~{fragments/cardHeader :: cardHeader(header=${messageVariant == 'self' ? #messages.msg('self-employment.header-self') : #messages.msgWithParams('self-employment.header', fieldData.get('householdMemberJobAdd'))})}"/> | |||
There was a problem hiding this comment.
Updated this text so that we would have a version for self and a version for others. The spanish translation wasn't lending itself to this and I imagine the vietnamese translation might have issues too
analoo
commented
Jan 30, 2024
analoo
commented
Jan 30, 2024
Updated to match new keys for self employment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.