Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pay frequency type issue resolved #591

Merged
merged 3 commits into from
Feb 1, 2024
Merged

pay frequency type issue resolved #591

merged 3 commits into from
Feb 1, 2024

Conversation

analoo
Copy link
Contributor

@analoo analoo commented Jan 31, 2024

No description provided.

@sree-cfa sree-cfa temporarily deployed to test-la-doc-uploader-pr-591 January 31, 2024 22:34 Inactive
@sree-cfa sree-cfa temporarily deployed to test-la-doc-uploader-pr-591 January 31, 2024 23:03 Inactive
@analoo analoo added the ready for review This PR is ready for code-review label Jan 31, 2024
@sree-cfa
Copy link
Contributor

@analoo I'm getting a 500 when I try to change the language on the pay period screen

@sree-cfa sree-cfa temporarily deployed to test-la-doc-uploader-pr-591 February 1, 2024 00:11 Inactive
@analoo
Copy link
Contributor Author

analoo commented Feb 1, 2024

@sree-cfa - I believe that the 500 errors when changing messages are current behavior. I tested it in Staging.

@analoo analoo requested a review from sree-cfa February 1, 2024 00:17
@sree-cfa
Copy link
Contributor

sree-cfa commented Feb 1, 2024

@sree-cfa - I believe that the 500 errors when changing messages are current behavior. I tested it in Staging.

Oh i see

Copy link
Contributor

@sree-cfa sree-cfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@analoo analoo merged commit 2414264 into main Feb 1, 2024
5 checks passed
@analoo analoo deleted the fix-job-flow-values branch February 1, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review This PR is ready for code-review
Projects
None yet
2 participants