Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify PDF mapping in journey tests #592

Merged
merged 2 commits into from
Feb 21, 2024
Merged

Verify PDF mapping in journey tests #592

merged 2 commits into from
Feb 21, 2024

Conversation

sree-cfa
Copy link
Contributor

@sree-cfa sree-cfa commented Jan 31, 2024

Verify content of generated PDF.

Blocked by FFL upgrade that includes the "generate-flattened" pdf param

@sree-cfa sree-cfa temporarily deployed to test-la-doc-uploader-pr-592 January 31, 2024 23:19 Inactive
@sree-cfa sree-cfa temporarily deployed to test-la-doc-uploader-pr-592 February 3, 2024 00:49 Inactive
@sree-cfa sree-cfa changed the title WIP - verify PDF mapping in journey tests (Blocked) verify PDF mapping in journey tests Feb 5, 2024
@sree-cfa sree-cfa temporarily deployed to test-la-doc-uploader-pr-592 February 20, 2024 18:18 Inactive
@sree-cfa sree-cfa changed the title (Blocked) verify PDF mapping in journey tests Verify PDF mapping in journey tests Feb 20, 2024
@sree-cfa sree-cfa temporarily deployed to test-la-doc-uploader-pr-592 February 20, 2024 18:33 Inactive
testPage.clickLink("SNAP Applicant PDF");
await().until(pdfDownloadCompletes());
File pdfFile = path.toFile().listFiles()[0];
try (PdfReader actualReader = new PdfReader(new FileInputStream(pdfFile));

Check warning

Code scanning / CodeQL

Potential input resource leak Warning

This FileInputStream is not always closed on method exit.
await().until(pdfDownloadCompletes());
File pdfFile = path.toFile().listFiles()[0];
try (PdfReader actualReader = new PdfReader(new FileInputStream(pdfFile));
PdfReader expectedReader = new PdfReader(new FileInputStream("src/test/resources/output/test_la_application_for_assistance.pdf"))) {

Check warning

Code scanning / CodeQL

Potential input resource leak Warning

This FileInputStream is not always closed on method exit.
@sree-cfa sree-cfa marked this pull request as ready for review February 20, 2024 18:41
@lkemperman-cfa lkemperman-cfa merged commit 72f7865 into main Feb 21, 2024
5 checks passed
@lkemperman-cfa lkemperman-cfa deleted the pdf-testing branch February 21, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants