Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throw validation error if day, month, or year are blank in household member birthday #594

Merged
merged 2 commits into from
Feb 1, 2024
Merged

Throw validation error if day, month, or year are blank in household member birthday #594

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cd2e5dd
Throw validation error if day, month, or year are blank in household …
spokenbird Feb 1, 2024
e9d4fdb
Fix extra parens
spokenbird Feb 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/main/java/org/ladocuploader/app/submission/actions/ValidateHouseholdBirthdate.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,8 @@ public Map<String, List<String>> runValidation(FormSubmission formSubmission, Su
String year = (String) inputData.get("householdMemberBirthYear");

// valid range does not enforce year so added an additional validation here
if((day + month + year).isBlank()) {
if((day.isBlank() || month.isBlank() || year.isBlank())) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think theres one extra layer of parenthesis

errorMessages.put(INPUT_NAME, List.of(translateMessage("error.format-dob")));
return errorMessages;
} else if (!Pattern.matches("\\d{4}",year)) {
errorMessages.put(INPUT_NAME, List.of(translateMessage("error.format-dob")));
Expand Down
Loading