Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Money on Hand is generated in PDF in non English Languages #598

Merged
merged 1 commit into from
Feb 3, 2024
Merged

Money on Hand is generated in PDF in non English Languages #598

merged 1 commit into from
Feb 3, 2024

Conversation

analoo
Copy link
Contributor

@analoo analoo commented Feb 1, 2024 •
edited
Loading

To test:

  1. Add personal info
  2. Add household members
  3. go to /householdMoneyOnHand
  4. Select some options
  5. Add some values in the amount section
  6. Download PDF and confirm on page 9 that the data is showing up correctly

@sree-cfa sree-cfa temporarily deployed to test-la-doc-uploader-pr-598 February 1, 2024 20:00 Inactive
@analoo analoo changed the title money on hand fixed Money on Hand is generated in PDF in non English Languages Feb 1, 2024
@analoo analoo added the ready for review This PR is ready for code-review label Feb 2, 2024
sree-cfa
sree-cfa approved these changes Feb 2, 2024
View reviewed changes
Copy link
Contributor

@sree-cfa sree-cfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@analoo analoo merged commit 4489104 into main Feb 3, 2024
5 checks passed
@analoo analoo deleted the fix-money-on-hand-types branch February 3, 2024 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sree-cfa sree-cfa sree-cfa approved these changes

Assignees
No one assigned
Labels
ready for review This PR is ready for code-review
Projects
None yet
Milestone
No milestone
2 participants
@analoo @sree-cfa