Add docUploadOwner and docUploadReviewOwner screens #704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
spokenbird
commented
Apr 16, 2024
spokenbird
commented
- Adds the above screens with the goal of associating a household member with an uploaded document.
- Create associations between household member and uploaded document
analoo
reviewed
Apr 17, 2024
| condition: ContinueAssociateDocType | ||
| - name: docUpload | ||
| docUploadReview: | ||
| docUploadOwner: |
There was a problem hiding this comment.
Tiny, non blocking. This reads easier when the sections are in order. I'd expect docUploadReviewTypes to be in line 542 and then docUploadOwner to be listed afterward.
analoo
reviewed
Apr 17, 2024
| helpText='', | ||
| content=~{::docWho}, | ||
| ariaDescribedBy=${fileId}, | ||
| label='', |
There was a problem hiding this comment.
we can typically omit label when ariaLabel exists.
|
LGTM. I would love to test once the tests pass and we can deploy |
|
QA'ed and looks good! |
analoo
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.