Spike - Add demo of different content on different domains #1156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Asheesh Laroia <alaroia@codeforamerica.org>
alaroia-cfa
changed the title
|
@alaroia-cfa will you take me through what actually changed in the routes files? |
bytheway875
reviewed
Jun 7, 2021
| class CtcDomain | ||
| def matches?(request) | ||
| app_base_domains = ["localhost", "getyourrefund.org", "staging.getyourrefund.org", "demo.getyourrefund.org"] | ||
| ctc_hosts = app_base_domains.map { |domain| ["ctc.#{domain}", "www.ctc.#{domain}"] }.flatten |
There was a problem hiding this comment.
Does this mean that the ctc domains should work fine out of the box in demo and staging? Should we attempt to push this to staging to validate that?
|
I think there are some things we need to configure in order to get this working on staging. Before we commit to going with this approach, should we ensure we can get it working on the staging environment? |
|
Got this working on staging after doing the Route53/Aptible setup that was necessary!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
localhost:3000/ looks like
ctc.localhost:3000/ looks like