Hub and efile submission page cleanups #4382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Heroku app: https://gyr-review-app-4382-fb3c763897c9.herokuapp.com/ |
embarnard
force-pushed
the
allow-transition-from-failed-to-rejected-for-tesing
branch
from
3541d9f
to
879ce6e
Compare
embarnard
changed the title
rickreyhsig
reviewed
Mar 22, 2024
Comment on lines
61
to
62
| <% errors = submission&.efile_submission_transitions&.where(to_state: 'rejected')&.last&.efile_errors if ['waiting', 'notified_of_rejection'].include?(submission.current_state) %> | ||
| <% errors&.each do |error| %> |
There was a problem hiding this comment.
For for readability sakes:
<% if ['waiting', 'notified_of_rejection'].include?(submission.current_state)
errors = submission&.efile_submission_transitions&.where(to_state: 'rejected')&.last&.efile_errors
end
%>
rickreyhsig
approved these changes
Mar 22, 2024
embarnard
deleted the
allow-transition-from-failed-to-rejected-for-tesing
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR shows the efile-error on the index page if the submission is in waiting or notified-of-rejected states, adds a transition to rejected button on the show page for testing only, cleans up the show a bit and corrects some of the descriptions on the efile-errors form page
