Fix for survey notification job

lib/tasks/send_survey_notifications.rake

@@ -5,17 +5,24 @@ namespace :survey_notifications do
     BATCH_SIZE = 10
     accepted_submissions = EfileSubmission.joins(:efile_submission_transitions)
                                           .where("efile_submission_transitions.to_state = 'accepted'")
+                                          .where("efile_submissions.data_source_type = 'StateFileAzIntake' OR efile_submissions.data_source_type = 'StateFileNyIntake'")
                                           .where.not("message_tracker #> '{messages.state_file.survey_notification}' IS NOT NULL")
 
     accepted_submissions.each_slice(BATCH_SIZE) do |batch|
       batch.each do |submission|
-        puts "Sending survey notification to #{submission.id}"
-        StateFile::MessagingService.new(
-          intake: submission.data_source,
-          submission: submission,
-          message: StateFile::AutomatedMessage::SurveyNotification,
-          body_args: { survey_link: survey_link(submission.data_source) }
-        ).send_message
+        intake = submission.data_source
+        if intake.nil?
+          # This should only happen for non state_filing submissions which have been filtered out up top.
+          puts "Skipping over submission #{submission.id} without an intake."
+        else
+          puts "Sending survey notification to #{submission.id}"
+          StateFile::MessagingService.new(
+            intake: intake,
+            submission: submission,
+            message: StateFile::AutomatedMessage::SurveyNotification,
+            body_args: { survey_link: survey_link(intake) }
+          ).send_message
+        end
       end
     end
   end

spec/tasks/send_survey_notifications_spec.rb

@@ -0,0 +1,13 @@
+require 'rails_helper'
+
+describe 'send_survey_notifications rake task' do
+  let!(:intake) { create :state_file_az_intake, email_address: "test@example.com", email_address_verified_at: 1.minute.ago }
+  let!(:efile_submission) { create :efile_submission, :for_state, :accepted, data_source: intake }
+  let!(:efile_submission_no_intake) { create :efile_submission, :for_state, :accepted, data_source: nil }
+  before(:all) do
+    Rails.application.load_tasks
+  end
+  it 'runs without error even when submission does not have an intake' do
+    Rake::Task['survey_notifications:send'].execute
+  end
+end