Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nil Redirect Fix #187308375 #4422

Merged
merged 3 commits into from
Mar 29, 2024
Merged

Nil Redirect Fix #187308375 #4422

merged 3 commits into from
Mar 29, 2024

Conversation

tofarr
Copy link
Contributor

@tofarr tofarr commented Mar 28, 2024

I think this is a path nobody expected to ever get run in prod, but it did actually happen (https://codeforamerica.sentry.io/issues/5096696710/?project=1880327&referrer=pivotal_plugin - that user who seemed to get the return status as accepted when transferring data from the IRS but later not accepted when they submitted.) So it needed some love:

  • Added translations for the error message
  • Always redirect back to return-state (Using the referrer will not work as there is not guaranteed to be a referrer.

Steps to reproduce the issue:

  • Open a new incognito tab, start a new intake, and get past the landing page:
image

Copy link

Heroku app: https://gyr-review-app-4422-a5f2cee2c293.herokuapp.com/
View logs: heroku logs --app gyr-review-app-4422 (optionally add --tail)

@tofarr tofarr merged commit 250259b into main Mar 29, 2024
7 checks passed
@tofarr tofarr deleted the nil-redirect-fix-#187308375 branch March 29, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants