Modify the check for verified emails to also look for verification on… #4501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ching accepted submission Co-authored-by: Tahsina Islam <tislam@codeforamerica.org>
… a matching intake (using ssn & address) Co-authored-by: Em Barnard-Shao <ebarnard@codeforamerica.org> Co-authored-by: Tahsina Islam <tislam@codeforamerica.org>
|
Heroku app: https://gyr-review-app-4501-3d178ed91b45.herokuapp.com/ |
Co-authored-by: Tahsina Islam <tislam@codeforamerica.org>
Co-authored-by: Tahsina Islam <tislam@codeforamerica.org>
jenny-heath
reviewed
Apr 17, 2024
| @@ -20,10 +20,10 @@ def message_tracker | |||
| @message_tracker ||= MessageTracker.new(data_source: data_source, message: message) | |||
| end | |||
|
|
|||
| def send_message | |||
| def send_message(use_verification=true) | |||
There was a problem hiding this comment.
Suggested change
| def send_message(use_verification=true) | |
| def send_message(use_verification: true) |
if you want to make it a named argument
jenny-heath
reviewed
Apr 17, 2024
| @@ -22,7 +22,7 @@ def send_efile_submission_accepted_message | |||
| intake: @intake, | |||
| submission: @submission, | |||
| message: message, | |||
| body_args: body_args).send_message | |||
| body_args: body_args).send_message(false) | |||
There was a problem hiding this comment.
Suggested change
| body_args: body_args).send_message(false) | |
| body_args: body_args).send_message(use_verification: false) |
jenny-heath
reviewed
Apr 17, 2024
| @@ -41,7 +41,7 @@ def send_efile_submission_rejected_message | |||
| submission: @submission, | |||
| message: message, | |||
| body_args: body_args | |||
| ).send_message | |||
| ).send_message(false) | |||
There was a problem hiding this comment.
Suggested change
| ).send_message(false) | |
| ).send_message(use_verification: false) |
jenny-heath
reviewed
Apr 17, 2024
| return nil if message_tracker.already_sent? && message.send_only_once? | ||
|
|
||
| send_email if @do_email && !intake.unsubscribed_from_email? | ||
| send_email(use_verification) if @do_email && !intake.unsubscribed_from_email? |
There was a problem hiding this comment.
Suggested change
| send_email(use_verification) if @do_email && !intake.unsubscribed_from_email? | |
| send_email(use_verification: use_verification) if @do_email && !intake.unsubscribed_from_email? |
Co-authored-by: Tahsina Islam <tislam@codeforamerica.org>
…check-when-messaging
Co-authored-by: Tim O'Farrell <tofarrell@codeforamerica.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… a matching intake (using ssn & address)