Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FYST-143 Fixed staging URLs which had been broken #4612

Merged
merged 2 commits into from
Jun 26, 2024
Merged

FYST-143 Fixed staging URLs which had been broken #4612

merged 2 commits into from
Jun 26, 2024

Conversation

tofarr
Copy link
Contributor

@tofarr tofarr commented Jun 26, 2024 •
edited
Loading

FYST-143

Is PM acceptance required?

  • Yes - don't merge until JIRA issue is accepted!
  • No - merge after code review approval

What was done?

How to test?

Screenshots (for visual changes)

Before

image

After

image

@github-actions GitHub Actions
Copy link

Heroku app: https://gyr-review-app-4612-7ccbd95eff7b.herokuapp.com/
View logs: heroku logs --app gyr-review-app-4612 (optionally add --tail)

jnf
jnf approved these changes Jun 26, 2024
View reviewed changes
Copy link
Contributor

@jnf jnf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@tofarr tofarr merged commit 677f77f into main Jun 26, 2024
8 checks passed
@tofarr tofarr deleted the FYST-143 branch June 26, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnf jnf jnf approved these changes

@mpidcock mpidcock mpidcock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tofarr @jnf @mpidcock